Derek Schuff
Derek Schuff
Generally LGTM, but maybe we should separate the dependence updates from the functional change :)
Yeah, USE_WSTRING_PATH is certainly the thing that controls whether we try to use `std::wstring` for paths. In addition to the constructors, there are also calls to `ifstream::open()` (e.g. in support/file.cpp)...
I haven't reviewed the code yet but I think this idea is generally good We did something similar for the [NaCl](https://chromium.googlesource.com/native_client/src/native_client/+/refs/heads/main/tools/redirector/) compiler (for a different reason, but a similar technique)....
I don't think we need to support WIndows 7 anymore. Neither Chrome nor Firefox does; I can't imagine developers using it either.
Regarding SmartScreeen, I would assume that if the clang and BInaryen binaries that we package are working, then whatever binary we build from this source should work too. Agreed that...
Just to link up some issues, there is related discussion in https://github.com/emscripten-core/emscripten/issues/20462 and https://github.com/emscripten-core/emscripten/issues/25116. In the latter I speculated that we might be able to do some partial reconstruction in...
I can confirm that running `--strip-debug` on an object file and then attempting to add it to an archive file breaks. When running a debug build with asserts, I got...
This same crash happens when stripping the object file first and then trying to add it to an archive. This suggests that the stripping is corrupting the object file in...
Actually looking at the file, the debug sections are gone, but the reloc sections that point to them are still there. Maybe the problem is that the linking section parser...
Unfortunately it doesn't look like it. Even if you remove the relocation sections, it looks like it's the invalid symbols in the symbol table (that point into the stripped debug...