d2lootfilter icon indicating copy to clipboard operation
d2lootfilter copied to clipboard

condition Class != Potion causes crash

Open qqkookie opened this issue 2 years ago • 3 comments

It seems that the condition Class != Potion or similar Class != expression causes hard crash on loading the filter file. Type != Super Healing Potion does not cause crash. And Class condition with non-existent class (due to spell error etc) always success and issues no error message. It make hard to track down error. Non existing class condition should issue warning.

qqkookie avatar Nov 24 '22 08:11 qqkookie

This is an incomplete project, I lost time and interest. But the following is in the readme

* Error handling. Filter just silently ignores errors right now.

It's known that errors are ignored. To track down issues I suggest using the /debug and/or the /test features.

dschu012 avatar Nov 24 '22 12:11 dschu012

Hmmm.. then may I edit and revise the source code more widely? i.e. not just small fix, but more revisions and improvement of basic functionalities of d2lootfilter and source code. I'd like to add most of improvements I suggested in the #31 by myself. If you are no longer interested in maintaining this project, I can volunteer.

qqkookie avatar Nov 28 '22 22:11 qqkookie

You're welcome to fork it and change it to your will.

dschu012 avatar Nov 28 '22 22:11 dschu012