Johannes Schindelin
Johannes Schindelin
Did we silently drop Vista support? I thought we still officially supported it...
Seems as if this could be the same issue as https://github.com/GitCredentialManager/git-credential-manager/issues/576. If it is, then https://github.com/git-for-windows/git-sdk-64/blob/b66f658faf70ae7de7656c46973d3b371dea1ab4/usr/bin/msys-2.0.dll should work around the issue, and https://github.com/git-for-windows/git-sdk-64/blob/b66f658faf70ae7de7656c46973d3b371dea1ab4%5E/usr/bin/msys-2.0.dll should not. @brechtsanders could you verify this...
> is this [git-for-windows/git#3936](https://github.com/git-for-windows/git/issues/3936)? If the `msys-2.0.dll` I asked @brechtsanders to try fixed the issue, then no, it isn't the same issue: The patches I integrated into Git for Windows'...
> @dscho Where exactly can I find the `msys-2.0.dll` you want me to try? It expired.
Try replacing your `msys-2.0.dll` with [Git for Windows' version](https://github.com/git-for-windows/git-sdk-64/blob/HEAD/usr/bin/msys-2.0.dll).
@brechtsanders then try with regular Cygwin. It's possible that it's a Cygwin issue, in which case they're usually pretty quick to fix 'em.
I believe that that's not the correct place, https://github.com/msys2/msys2-runtime/blob/b671a59da80fa1db6115e3275149f9639681453a/winsup/cygwin/path.cc#L2297-L2366 should be the correct one. But I am seeing `CopyFile()` being called with wide-character strings...
> The w_ prefix is a lie. It fooled me!
I am _really_ concerned about a change like this. It is _prone_ to break existing setups. Look e.g. at the lengths Git for Windows goes to quote things accurately for...
> Interestingly enough, I didn't see this issue raised in the review in upstream cygwin so far, except for the last bullet at https://cygwin.com/pipermail/cygwin-patches/2020q2/010307.html (which seemed to go unanswered). It's...