Johannes Schindelin

> > The Microsoft logo in dark mode has been mangled quite a bit > > Hmm. I'm not even sure that this is a legitimate use of the trademark,...

@To1ne I _think_ that I have addressed all of the concerns you raised in https://github.com/git/git-scm.com/pull/1888#issuecomment-2458954252, could I ask you to take another look? As usual, I've test-deployed the changes to...

> So, what's left? I think that's it 😉 Should I merge it now?

> Also I've found one quirk, when you manually set it to light mode, but your system says dark mode, you get this. Hah, I forgot about this. The problem...

@To1ne do you think this is ready to merge? I kind of want to, and then take it from there.

> Do we have/need a rollback strategy if we learn these changes were not ready to be published? Yes, there is a "Revert" button once this PR is merged. And...

I think the canonical way to store a credential is via [`git credential approve`](https://git-scm.com/docs/git-credential), not via the credential helper. Does that help? If you _need_ to use `git credential-manager store`,...

> Thanks, I'll look into approve (it wasn't very intuitive :)) Heh. Git's credential machinery was not designed to be used like that. For pre-authentication, I think the idea was...

> the `[credential]` directive may sometimes contain sensitive info That should not be the case, ever, if all you use is Git Credential Manager. Granted, other credential helpers sometimes put...

> What happens for me is that after I authenticate in the browser tab which gets opened, GCM is adding something similar to the following to my global gitconfig file:...