Johannes Schindelin
Johannes Schindelin
@Masmiseim36 ping?
I restarted the failed test (it failed for unrelated reasons in a flaky test, the re-run should "fix" it). You will still be required to add your [Sign-off](https://git-scm.com/docs/SubmittingPatches#sign-off), GitGitGadget won't...
Hmm. I think the Signed-off-by: line is _still_ incomplete, as it only says "Markus", not "Markus Klein". The reviewers on the Git mailing list won't like that, https://git-scm.com/docs/SubmittingPatches#sign-off specifically states:...
Looks good to me. I think it's `/submit` time!
> Thanks for the hint. I’ve fixed this Best Regards Markus This was the only information in that otherwise garbled reply, right?
> > Thanks for the hint. I’ve fixed this Best Regards Markus I was able to verify this by looking at this: https://github.com/git/git/commit/a59ca4e27b7879f07d99d56cb972761e59714731.patch > This was the only information in...
For what it's worth: by "initial comment", I meant the first comment on the PR, i.e. the PR description, not the commit message...
> Keys generated using `ssh-keygen -t ecdsa` or similar will be rejected as literal SSH keys because the prefix is `ecdsa-sha2-nistp256`, `ecdsa-sha2-nistp384` or `ecdsa-sha2-nistp521`. > > This was acknowledged as...
> @dscho Sure, does that look any better? Is there a specific format I need to follow? Looks good to me!