angular2-json-schema-form icon indicating copy to clipboard operation
angular2-json-schema-form copied to clipboard

fxLayoutWrap no longer exists

Open jihuiwang opened this issue 7 years ago • 13 comments

I was using material design framework but received an error Can't bind to 'fxLayoutWrap' since it isn't a known property of 'flex-layout-root-widget'.

I checked angular/flex-layout on github and found that fxLayoutWrap was removed since Nov 30, 2017.

jihuiwang avatar Feb 23 '18 03:02 jihuiwang

it is used in 'src/lib/src/framework-library/material-design-framework/flex-layout-section.component.ts'

jihuiwang avatar Feb 23 '18 04:02 jihuiwang

same issue here!!

oliverrenner avatar Mar 01 '18 16:03 oliverrenner

@oliverrenner remove the [fxLayoutWrap] Directive from the template in 'src/lib/src/framework-library/material-design-framework/flex-layout-section.component.ts' make it work

jihuiwang avatar Mar 02 '18 01:03 jihuiwang

@jihuiwang To be precise, it was removed in 5.0.0-beta.13 on 22nd February in 2018 but was deprecated earlier, maybe the date you mentioned. See https://github.com/angular/flex-layout/blob/master/CHANGELOG.md#breaking-changes

If the fxLayoutWrap directive is there a corresponding wrap should likely be added to the fxLayout property to keep the same functionality. I.e. from fxLayout="row" to fxLayout="row wrap"

Koslun avatar Mar 03 '18 00:03 Koslun

use fxLayout="row wrap"

beeing avatar Mar 03 '18 04:03 beeing

@Koslun yes, the error appears with the latest version of angular/flex-layout, which is 5.0.0-beta.13 now i roll back to the previous one (2.0.0-beta.12). and it works again.

jihuiwang avatar Mar 06 '18 03:03 jihuiwang

@jihuiwang yes, I've done the same for now.

Koslun avatar Mar 06 '18 13:03 Koslun

Work around, removing the (part of) line [fxLayoutWrap]="options?.fxLayoutWrap"\n from angular2-json-schema-form.es5 file, worked for me to upgrade to flex-layout 5.0.0-beta.13. Not fully tested yet, but could help...

rroeneman avatar Mar 13 '18 10:03 rroeneman

Any update on this issue? Facing the same

vatsalpande avatar Mar 26 '18 06:03 vatsalpande

@vatsalpande fixed in PR #230

Koslun avatar Mar 26 '18 10:03 Koslun

Any ETA on the release that includes PR #230 ?

catchshyam avatar Apr 03 '18 10:04 catchshyam

Does anyone have a solution in anticipation of the pull request?

Theyssen avatar Apr 23 '18 08:04 Theyssen

@Theyssen Using a forked version of this repo containing the above PR. Steps to do so are described in above PR: https://github.com/dschnelldavis/angular2-json-schema-form/pull/230#issuecomment-383591628

Koslun avatar Apr 23 '18 17:04 Koslun