xPSDesiredStateConfiguration icon indicating copy to clipboard operation
xPSDesiredStateConfiguration copied to clipboard

Remove $fileExists condition before CheckSum

Open XVII opened this issue 3 years ago • 3 comments

Pull Request (PR) description

Test the CheckSum if it's provided -- allow it to override cached attribute check.

This Pull Request (PR) fixes the following issues

  • Fixes #723

Task list

  • [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
  • [ ] Resource documentation added/updated in README.md.
  • [x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
  • [ ] Comment-based help added/updated.
  • [x] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [ ] Unit tests added/updated. See DSC Community Testing Guidelines.
  • [x] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • [x] New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

XVII avatar Jul 05 '21 06:07 XVII

Codecov Report

Merging #724 (eb7f67d) into main (475885c) will decrease coverage by 0%. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           main   #724     +/-   ##
=====================================
- Coverage    72%    72%     -1%     
=====================================
  Files        30     30             
  Lines      4427   5838   +1411     
=====================================
+ Hits       3213   4209    +996     
- Misses     1214   1629    +415     
Impacted Files Coverage Δ
.../DSCResources/DSC_xRemoteFile/DSC_xRemoteFile.psm1 89% <ø> (ø)
...ces/DSC_xPackageResource/DSC_xPackageResource.psm1 78% <0%> (-2%) :arrow_down:
...sources/DSC_xGroupResource/DSC_xGroupResource.psm1 69% <0%> (-1%) :arrow_down:
...xEnvironmentResource/DSC_xEnvironmentResource.psm1 91% <0%> (-1%) :arrow_down:
...ces/DSC_xServiceResource/DSC_xServiceResource.psm1 93% <0%> (-1%) :arrow_down:
...Resources/DSC_xUserResource/DSC_xUserResource.psm1 53% <0%> (-1%) :arrow_down:
...urces/DSC_xScriptResource/DSC_xScriptResource.psm1 100% <0%> (ø)
...sionConfiguration/DSC_xPSSessionConfiguration.psm1 0% <0%> (ø)
...urces/DSC_xWindowsFeature/DSC_xWindowsFeature.psm1 88% <0%> (+1%) :arrow_up:

codecov[bot] avatar Jul 05 '21 07:07 codecov[bot]

/AzurePipeline run

PlagueHO avatar Oct 11 '22 05:10 PlagueHO

Azure Pipelines successfully started running 1 pipeline(s).

azure-pipelines[bot] avatar Oct 11 '22 05:10 azure-pipelines[bot]