Resource DhcpServerDnsDynamicUpdates

[dan-hughes]

Pull Request (PR) description

Add resources:

• DhcpServerv4DnsDynamicUpdates
• DhcpServerv6DnsDynamicUpdates

This Pull Request (PR) fixes the following issues

• Fixes #65

Task list

• [ ] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
• [ ] Resource documentation added/updated in README.md.
• [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
• [ ] Comment-based help added/updated.
• [ ] Localization strings added/updated in all localization files as appropriate.
• [ ] Examples appropriately added/updated.
• [ ] Unit tests added/updated. See DSC Community Testing Guidelines.
• [ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• [ ] New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[dan-hughes]

Blocked by #94

[dan-hughes]

@johlju, thought's on IPv4 and IPv6 functionality being in the same module? It's a lot less complex in this case to separate them as both don't use the same parameters.

[johlju]

Can we move those parameters that are equal to a parent class? Similar to SqlResourceBase but maybe call it something like DhcpServerDnsDynamicUpdatesBase unless the parameters can be used for even more resources then maybe a more generic name, but might be hard to know now 🤔

Also, is it possible to use an enum as datatype for a key property? I did not know that.

[johlju]

thought's on IPv4 and IPv6 functionality being in the same module?

Didn't answer your actual question. 🙂 Assuming you mean same resource. I have no issue with them being separated as long as the properties of one cannot be enforced by the other. If they can then there could be a "ping-pong" behavior if they were to be in the same configuration with different values. Then I would recommend them to be in the same resource 🤔

[dan-hughes]

Correct, I did mean resource.

I think this case it's easier to keep separate, I may look at a base class though as it will reduce some duplication.

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[johlju]

@dan-hughes is this ready to be revied if the tests passes?

[dan-hughes]

No, needs more tests I think.

And testing on a real system.