cNtfsAccessControl icon indicating copy to clipboard operation
cNtfsAccessControl copied to clipboard

Published 20 hours ago • verified publisher icon dsccommunity

cNtfsPermissionEntry.psm1

Open shubhamgupta514 opened this issue 5 years ago • 4 comments

Do not use "APPLICATION PACKAGE AUTHORITY\ALL RESTRICTED APPLICATION PACKAGES " but "ALL RESTRICTED APPLICATION PACKAGES " only as Principal and I have done few modifications to support that cNtfsPermissionEntry DscResource.

shubhamgupta514 avatar Sep 19 '19 05:09 shubhamgupta514

@SNikalaichyk Could you review it and merge it .Please do let me know if you have any queries

shubhamgupta514 avatar Sep 19 '19 05:09 shubhamgupta514

Hi @shubhamgupta514, first of all thanks for submitting this PR! This is quite a big change, and thus will require a thorough review and testing. I would also want to get more details about the issue(s) this PR is meant to address. After a quick look:

  • The code needs to match the overall formatting style, look, and feel of the module.
  • The Convert-FileSystemRightsInteger function needs to have tests and follow the style as it's very messy (aliases, lots of comments etc).

SNikalaichyk avatar Sep 19 '19 16:09 SNikalaichyk

@SNikalaichyk Thanks for your comments.

I am not the original author of Convert-FileSystemRightsInteger. I copied the source code from Technet and already mentioned the link for the same as comment above the function.

shubhamgupta514 avatar Sep 19 '19 17:09 shubhamgupta514

About the PR, I am getting an error "Some or all identity references could not be translated" I am trying modifying the permissions for APPLICATION PACKAGE AUTHORITY\ALL RESTRICTED APPLICATION PACKAGES on a particular file or folder.

What I found after some debugging if we only use "ALL RESTRICTED APPLICATION PACKAGES" without the domain and use of the sid of the same in access rule as an argument in modifyaccessrule. Everything is working fine.

shubhamgupta514 avatar Sep 19 '19 17:09 shubhamgupta514