WebAdministrationDsc icon indicating copy to clipboard operation
WebAdministrationDsc copied to clipboard

Published 20 hours ago • verified publisher icon dsccommunity

MSFT_xWebsite support for FTP websites

Open TheDudeCode opened this issue 8 years ago • 17 comments

The MSFT_xWebsite currently lacks support for managing FTP websites. I would like to bring a vote for implementing this.

TheDudeCode avatar Jan 13 '16 08:01 TheDudeCode

Seems like a good idea to me.

tysonjhayes avatar Jan 14 '16 18:01 tysonjhayes

I was planning to support FTP bindings in pull request #69 but decided to postpone it. It required to rework the logic behind the site's Started/Stopped state. For example if a site has both FTP and HTTP bindings, and you want the Website to be Stopped, the FTP site will be still Started. As soon as my PR is merged, I will be able to start working on it.

websitewithftpstate

SNikalaichyk avatar Jan 15 '16 13:01 SNikalaichyk

Hello! Any update on this? Last comment is 3 months old. I wonder if @SNikalaichyk had the time to have a look into this. Thanks

gigi81 avatar Apr 19 '16 12:04 gigi81

Hi @gigi81, Unfortunately no.

SNikalaichyk avatar Apr 19 '16 13:04 SNikalaichyk

@SNikalaichyk is this still on your radar? It look a emm "interesting" one to fix

nzspambot avatar May 27 '16 04:05 nzspambot

@nzspambot , No. Please feel free to implement it.

SNikalaichyk avatar May 27 '16 18:05 SNikalaichyk

@SNikalaichyk I'll look at this soonish, I had a thought about this.

What do you think about splitting this into a new module called xFTP so it is not under xWebsite? Where it would create an FTP site and also allow FTP on an existing website if needed?

@tysonjhayes :point_up: your input is also valued please

nzspambot avatar Jun 14 '16 23:06 nzspambot

So to show a bit of ignorance, how does this differ from changing a binding/port on a website (something that could be added to xWebsite) and needing to spawn its own resource? I'm good with either one as long as it makes sense.

tysonjhayes avatar Jun 15 '16 00:06 tysonjhayes

I was thinking about the FTP settings vs a plain FTP binding so

either:

  • a Resource which can change FTP settings eg FTP Authen, FTP Auth, FTP Dir Brow, FTP Ssl, FTP User etc

or

  • add to xWebsite only ability to add FTP bindings

I'm pro former but latter is quicker

nzspambot avatar Jun 15 '16 00:06 nzspambot

Wouldn't it be a bit of both though? I'm thinking the former sounds pretty good though.

tysonjhayes avatar Jun 15 '16 20:06 tysonjhayes

well former has etc so yes would encapsulate bindings ;)

nzspambot avatar Jun 15 '16 22:06 nzspambot

ok since I can I will start xFTP this weekend

nzspambot avatar Jun 24 '16 03:06 nzspambot

Waiting for PR https://github.com/PowerShell/xWebAdministration/pull/202.

rosberglinhares avatar May 27 '17 09:05 rosberglinhares

The PR #202 was closed. Shouldn't we close this issue too?

rosberglinhares avatar Jul 12 '17 22:07 rosberglinhares

I have reopen the PR and labeled it abandoned and hopefully the author wish to continue the work on it, otherwise I hope another contributor want to continue the work.

johlju avatar Apr 25 '18 13:04 johlju

The PR #202 has been closed again, should it be opened again so someone else can work on this. This functionality would be really helpful.

mvandriessen avatar Apr 09 '19 07:04 mvandriessen

I think someone else can continue the work and send in a new PR. Can anyone pick up PR #202?

See this how to continue working on an abandoned PR. https://github.com/PowerShell/DscResources/blob/master/GettingStartedWithGitHub.md#how-to-continue-working-on-a-pull-request-pr-when-an-author-contributor-is-unable-to-complete-it

johlju avatar Apr 09 '19 10:04 johlju