WebAdministrationDsc icon indicating copy to clipboard operation
WebAdministrationDsc copied to clipboard

BREAKING CHANGE: Introducing native ReverseDSC support for the module

Open NikCharlebois opened this issue 4 years ago • 4 comments

Pull Request (PR) description

Native ReverseDSC Support

This Pull Request (PR) fixes the following issues

N/A

Task list

  • [ ] Added an entry under the Unreleased section of the change log in the README.md. Entry should say what was changed, and how that affects users (if applicable).
  • [ ] Resource documentation added/updated in README.md.
  • [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
  • [ ] Comment-based help added/updated.
  • [ ] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
  • [ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • [ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

NikCharlebois avatar Sep 12 '19 17:09 NikCharlebois

Codecov Report

Merging #442 into dev will increase coverage by 4.56%. The diff coverage is 91.79%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #442      +/-   ##
==========================================
+ Coverage   90.85%   95.42%   +4.56%     
==========================================
  Files          17       18       +1     
  Lines        2461     2796     +335     
==========================================
+ Hits         2236     2668     +432     
+ Misses        225      128      -97
Impacted Files Coverage Δ
Modules/ReverseDSCCollector.psm1 0% <0%> (ø)
..._xIisMimeTypeMapping/MSFT_xIisMimeTypeMapping.psm1 100% <100%> (ø) :arrow_up:
...ApplicationHandler/MSFT_WebApplicationHandler.psm1 100% <100%> (ø) :arrow_up:
...SCResources/MSFT_xIIsHandler/MSFT_xIisHandler.psm1 100% <100%> (ø) :arrow_up:
...FT_xWebConfigProperty/MSFT_xWebConfigProperty.psm1 93.33% <100%> (+0.35%) :arrow_up:
...yCollection/MSFT_xWebConfigPropertyCollection.psm1 98.01% <100%> (+0.06%) :arrow_up:
...WebVirtualDirectory/MSFT_xWebVirtualDirectory.psm1 93.42% <100%> (+4.78%) :arrow_up:
...FT_xWebConfigKeyValue/MSFT_xWebConfigKeyValue.psm1 94.23% <100%> (+1.73%) :arrow_up:
..._xWebAppPoolDefaults/MSFT_xWebAppPoolDefaults.psm1 98.03% <100%> (+0.6%) :arrow_up:
...Resources/MSFT_xSSLSettings/MSFT_xSSLSettings.psm1 84.05% <100%> (+5.62%) :arrow_up:
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e04e964...698aead. Read the comment docs.

codecov-io avatar Sep 12 '19 18:09 codecov-io

Linked to #443

NikCharlebois avatar Sep 16 '19 16:09 NikCharlebois

@regedit32 & @johlju Sorry I had to spam you with all these commits. Existing Resources were not even at par with the code Cov requirements in their previous status. I believe all is now ready for a second round of reviews. Cheers!

NikCharlebois avatar Sep 16 '19 21:09 NikCharlebois

There are a lot of duplicated code introduced with this change, I also want to look over this to see that it actually the correct way of doing this. Please continue resolving comments on this change, but I will add an 'on hold' label for the time-being so we have chance to discuss this.

I have offline conversation with @NikCharlebois about this, but I have not have time to get back to that yet.

johlju avatar Oct 24 '19 07:10 johlju