New feature: IisMimeTypeMapping can update the mime type for an existing extension

[richardhauer]

Resolves issue #262. This PR addresses the case where there is already a defined mapping for an extension but the mimeType value is different. In this case the Set-TargetResource will update the existing item, rather than attempt to create a new one, which results in a key violation (as this element group is keyed on @fileExtension).

---

This change is 

[msftclas]

Hi @richardhauer, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution! In order for us to evaluate and accept your PR, we ask that you sign a contribution license agreement. It's all electronic and will take just minutes. I promise there's no faxing. https://cla.microsoft.com.

TTYL, MSBOT;

[mbreakey3]

Looks like you just need to switch your tabs to spaces.

[richardhauer]

I did that in a subsequent commit in my fork, but I think I have to cancel the PR and resubmit now don't I :(

-------- Original message -------- From: Mariah [email protected] Date: 1/12/2016 4:13 AM (GMT+10:00) To: PowerShell/xWebAdministration [email protected] Cc: Richard Hauer [email protected], Mention [email protected] Subject: Re: [PowerShell/xWebAdministration] New feature: IisMimeTypeMapping can update the mime type for an existing extension (#263)

Looks like you just need to switch your tabs to spaces.

You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/xWebAdministration/pull/263#issuecomment-263933666, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AANyD0bynRfXCF-EQhmvjQFgghSAE10bks5rDa6ggaJpZM4LAC6s.

 

 

[mbreakey3]

You shouldn't have to... As long as your forked branch is still hooked up this PR

[tysonjhayes]

Hi @richardhauer are you till working on this? Happy to help if needed, but I'll need you to sign the cla as well.

[nickdurcholz]

We would very much like to see this PR fixed. What needs to be done in order to move it along?

[johlju]

@richardhauer are you still able to work on this pull request? If so I can help you review it and get it merged. We should have tests that test this scenario. If you can't work on this pull request, no worries, then I will label it as abandoned so that someone else can take over the work. 🙂

[johlju]

Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again.

[richardhauer]

Sorry Johan.

I’m flat out with work stuff at the moment and totally forgot about this.

Richard Hauer CTO

PING Works 1-7 Albion Place, Sydney NSW 2000 p: +61 2 9321 1551tel:+61%202%209321%201551 | www.ping-works.com.auhttps://www.ping-works.com.au d: +61 2 9321 1556tel:+61%202%209321%201556 | m: +61 414 189 170tel:+61%20414%20189%20170 Download a vCardhttps://ping-vcards.azurewebsites.net/api/GenerateVCF?name=richard.hauer

---

From: Johan Ljunggren [email protected] Sent: Wednesday, May 23, 2018 9:42:16 PM To: PowerShell/xWebAdministration Cc: Richard Hauer; Mention Subject: Re: [PowerShell/xWebAdministration] New feature: IisMimeTypeMapping can update the mime type for an existing extension (#263)

Labeling this PR as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on the PR is taken up again.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/PowerShell/xWebAdministration/pull/263#issuecomment-391316742, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AANyD4pGwkD6f1qHyoxipF9HNdEn9J7qks5t1UsYgaJpZM4LAC6s.

[johlju]

@richardhauer No worries. If you have time to continue working on it later on, ping me and I help you review it.