WSManDsc icon indicating copy to clipboard operation
WSManDsc copied to clipboard

WSManDsc: Convert Tests to Pester 5

Open dan-hughes opened this issue 1 year ago • 4 comments

Pull Request (PR) description

Convert tests to Pester 5

This Pull Request (PR) fixes the following issues

  • Fixes #99

Task list

  • [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
  • [ ] Resource documentation added/updated in README.md.
  • [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
  • [ ] Comment-based help added/updated.
  • [x] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [x] Unit tests added/updated. See DSC Community Testing Guidelines.
  • [x] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • [x] New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

dan-hughes avatar Jul 14 '24 15:07 dan-hughes

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98%. Comparing base (6f4163d) to head (7ecf82c). Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff          @@
##           main   #105    +/-   ##
====================================
+ Coverage    88%    98%   +10%     
====================================
  Files         3      3            
  Lines       310    292    -18     
====================================
+ Hits        274    288    +14     
+ Misses       36      4    -32     
Files with missing lines Coverage Δ
.../DSCResources/DSC_WSManConfig/DSC_WSManConfig.psm1 100% <100%> (ø)
...Resources/DSC_WSManListener/DSC_WSManListener.psm1 98% <100%> (+14%) :arrow_up:
...DSC_WSManServiceConfig/DSC_WSManServiceConfig.psm1 100% <100%> (ø)

codecov[bot] avatar Jul 14 '24 15:07 codecov[bot]

@johlju, @PlagueHO,

Please can someone review when time permits?

dan-hughes avatar Jul 17 '24 10:07 dan-hughes

Thanks for submitting @dan-hughes - awesome stuff! I'll get onto reviewing in the weekend.

PlagueHO avatar Jul 18 '24 07:07 PlagueHO

Sorry for not getting onto this yet - have had some other issues come up that need to deal with. Might have to be in the week :/

PlagueHO avatar Jul 20 '24 10:07 PlagueHO

Just need to get @kilasuit to sign off on comment and can merge.

PlagueHO avatar Aug 28 '24 08:08 PlagueHO

Good to merge :-)

kilasuit avatar Aug 28 '24 16:08 kilasuit