UpdateServicesDsc icon indicating copy to clipboard operation
UpdateServicesDsc copied to clipboard

Change languages to String array type in UpdateServicesServer Get-TargetResource return value

Open jortencio opened this issue 1 year ago • 4 comments

Pull Request (PR) description

Updates the returned value for the languages value in the return value for UpdateServicesServer Get-TargetResource function

This Pull Request (PR) fixes the following issues

Fixes #76

Task list

  • [x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
  • [ ] Resource documentation added/updated in README.md.
  • [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
  • [ ] Comment-based help added/updated.
  • [ ] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [x] Unit tests added/updated. See DSC Resource Testing Guidelines.
  • [ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • [ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

jortencio avatar Jul 18 '23 03:07 jortencio

Hello @jortencio thanks for your contribution. Can you complete the CHANGELOG.md file ?

NicolasBn avatar Sep 26 '23 13:09 NicolasBn

Hi @NicolasBn , I have updated the CHANGELOG.md file as requested to reflect the changes in this PR.

jortencio avatar Oct 09 '23 22:10 jortencio

Hi @jortencio thank you for your change. In your issue @sooyean-hoo referenced the same issue with Products collection. Can you add this fix in your PR? And maybe added some pester tests to cover your changes?

NicolasBn avatar Oct 11 '23 16:10 NicolasBn

Hi @NicolasBn as requested I have added pester tests to cover my changes. Regarding the products collection, I had a brief look and there doesn't seem to be an issue with the implementation for it.

jortencio avatar Nov 01 '23 03:11 jortencio