UpdateServicesDsc
UpdateServicesDsc copied to clipboard
UpdateServicesServer, UpdateServicesApprovalRule: Fixing Products processing, verbose output
Pull Request (PR) description
- Fixed
UpdateServicesServer
andUpdateServicesApprovalRule
- Process multiple product categories with the same name correctly (e.g. "Windows Admin Center")
- Verbose output of Products only displayed one product
- Fixed verbose output of Languages in
UpdateServiceServer
- Fixed verbose output of WSUS server in
UpdateServicesApprovalRule
This Pull Request (PR) fixes the following issues
- Fixes #61
- Fixes #62
- Fixes #63
Task list
- [X] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
- [ ] Resource documentation added/updated in README.md.
- [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
- [ ] Comment-based help added/updated.
- [ ] Localization strings added/updated in all localization files as appropriate.
- [ ] Examples appropriately added/updated.
- [ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
- [ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
- [X] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.
I think I'll need a bit of advice on how to deal with all the failed checks, as they seem to be mostly unrelated to the changes that I made. Should I ignore them? Or do they need to be fixed first, before my changes can be accepted?
Project likes dead. How can we made progression in it that the pull request are approved?
Is this project abandoned?
No, but I need to be reminded (on slack) or see the notifications. We also need more reviewers that can eventually help maintain the repo. I'll try to have a look this weekend.
Curious if this PR will be merged?
@NicolasBn has this been included part of your merged changes?
@TheBlackMini or @luzkenin are you able to rebase this branch and re-submit a PR.
@gaelcolas Indeed. To cover issue #61, I need to update UpdateServicesApprovalRule
resource.
So, @NicolasBn do I need to do anything?
@TheBlackMini I don't have any time before next week. If you don't want to wait, you can submit your PR :)
I worked on a solution here : Get-UpdateServicesDscProduct
I created a function to find all products based on value passed on Products
property.
I 'just' need to use it in UpdateServicesApprovalRule
, and adapt pester tests.
It was a few month ago. So I need times to reintegrate my code :)