SQLRS: Various improvements

[randomnote1]

Pull Request (PR) description

• Added Power BI Report Server support
• Added the ability to change the service account
• Added the ability to define the database name

This Pull Request (PR) fixes the following issues

• Fixes #148
• Fixes #149
• Fixes #587
• Fixes #626
• Fixes #860
• Fixes #936

Task list

• [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
• [x] Resource documentation updated in the resource's README.md.
• [x] Resource parameter descriptions updated in schema.mof.
• [x] Comment-based help updated, including parameter descriptions.
• [x] Localization strings updated.
• [x] Examples updated.
• [x] Unit tests updated. See DSC Community Testing Guidelines.
• [ ] Integration tests updated (where possible). See DSC Community Testing Guidelines.
• [x] Code changes adheres to DSC Community Style Guidelines.

---

This change is 

[codecov[bot]]

Codecov Report

Merging #1758 (04685ba) into main (c780423) will decrease coverage by 7%. The diff coverage is 35%.

:exclamation: Current head 04685ba differs from pull request most recent head 3b225a3. Consider uploading reports for the commit 3b225a3 to get more accurate results

@@          Coverage Diff           @@
##           main   #1758     +/-   ##
======================================
- Coverage    92%     85%     -7%     
======================================
  Files        85      36     -49     
  Lines      7640    6490   -1150     
======================================
- Hits       7038    5533   -1505     
- Misses      602     957    +355     

Flag	Coverage Δ
unit	85% <35%> (-7%)	:arrow_down:

Impacted Files	Coverage Δ
source/DSCResources/DSC_SqlRS/DSC_SqlRS.psm1	40% <35%> (-60%)	:arrow_down:
...dules/SqlServerDsc.Common/SqlServerDsc.Common.psm1	98% <100%> (-1%)	:arrow_down:

... and 49 files with indirect coverage changes

[johlju]

I'm waiting for the build workers to get the Windows patch for DSC so the integration tests can run. I will review then.

[randomnote1]

Looks like my Azure VMs started working again last week, so, hopefully soon!

[johlju]

/AzurePipelines run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[johlju]

@randomnote1 the integration test runs now - there are some failing tests in integration and unit tests. Let me know when they pass and I review.

[randomnote1]

@johlju, how do we log into the build servers to troubleshoot what is wrong? I recall seeing something somewhere, but I don't remember where!

[johlju]

It is not possible with the Azure DevOps build servers. It was possible way back when we used AppVeyor. I usually add debug verbose messages to see how far it comes before it throws to locate the line that fails. Not optimal, but often only way to find the issue if unit tests don’t catch it.

[randomnote1]

/AzurePipelines run

[azure-pipelines[bot]]

Commenter does not have sufficient privileges for PR 1758 in repo dsccommunity/SqlServerDsc

[randomnote1]

@johlju, looks like the only failure in the pipelines was well before SqlRs was attempted. Can you re-start the pipeline to verify?

[johlju]

Restarted.

[johlju]

AzurePipelines run

[johlju]

Restart all jobs again because SQL2016 for one job only ran for 10 minutes before failing without stopping the pipeline.

[johlju]

/AzurePipelines run

[azure-pipelines[bot]]

Azure Pipelines successfully started running 1 pipeline(s).

[johlju]

Now both jobs for SQL2016 seems to fail on the same spot.

[randomnote1]

All right, thanks. I'll continue troubleshooting

[randomnote1]

@johlju, what's going on with the build right now? I keep getting this from AppVeyor:

The build phase is set to "MSBuild" mode (default), but no Visual Studio project or solution files were found in the root directory. If you are not building Visual Studio project switch build mode to "Script" and provide your custom build command.

[johlju]

@randomnote1 I added Appveyor as a build job for debug purpose. If it helps you. Haven't merged the README.md yet (but as soon as the tests passes), but you can read here: https://github.com/dsccommunity/SqlServerDsc/blob/03f4a281044a950f43f7b7fd25f2234924e5653a/tests/Integration/README.md#debugging

[johlju]

I just merged the appveyor.yml so you won't get the above error.

[johlju]

You have to rebase to get that though. 🙂

[randomnote1]

Awesome, you're the man! Thanks!

[johlju]

You have to uncomment a row in appveyor.yml to have the build worker online after the tests finishes. I didn't want to do that by default since for each commit it would hold up other builds that use AppVeyor still.

[johlju]

Saw that it doesn't work to add $blockRdp = $true to the init: step. Must add this in appveyor.yml to paus the build at the end of the run. I will update the file on main-branch.

on_finish:
  - ps: $blockRdp = $true; iex ((new-object net.webclient).DownloadString('https://raw.githubusercontent.com/appveyor/ci/master/scripts/enable-rdp.ps1'))

[johlju]

@randomnote1 how does it go finding the cause of the failing tests? Would of course be great if this worked for all versions , but if you see that there is an issue getting this to work for the Reporting Services 2016 should we just add logic that if it is 2016 then it uses the previous (simpler) functionality? Then we could try to get the SQL 2016 moved to new functionality in a new PR? Just a suggestion to unblock you, you decide. Let me know if I can help with anything.

[randomnote1]

I found where and why the issue is occurring. I just haven't had time to think through resolutions yet.

[johlju]

@randomnote1 you need to rebase this PR so it runs the tests again. 🙂

[randomnote1]

Yup, working on it. The changes to the rebase conflict resolution in VS Code is weird. Probably gonna have to manually fix the ChangeLog

[johlju]

@randomnote1 was hoping to get in this PR before release next major release. Do you think it is gonna take a while to get the tests to pass (to fix this issue) so I should just release a new version?