NetworkingDsc icon indicating copy to clipboard operation
NetworkingDsc copied to clipboard

[NetAdapterRename] Allow rename with HyperV Device Naming

Open nyanhp opened this issue 1 year ago • 4 comments

Pull Request (PR) description

On Hyper-V VMs, if Device Naming is configured, an advanced property is present that can be used to filter for a NetAdapter renaming.

This Pull Request (PR) fixes the following issues

None

Task list

  • [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
  • [x] Resource documentation added/updated in README.md.
  • [x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
  • [x] Comment-based help added/updated.
  • [ ] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [x] Unit tests added/updated. See DSC Community Testing Guidelines.
  • [ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • [x] New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

nyanhp avatar Apr 18 '23 12:04 nyanhp

Pipeline fails due to https://github.com/dsccommunity/DscResource.DocGenerator/issues/131

nyanhp avatar Apr 18 '23 12:04 nyanhp

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97%. Comparing base (9d6e70d) to head (bdc3077). Report is 4 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #523   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        28     28           
  Lines      2078   2081    +3     
===================================
+ Hits       2028   2031    +3     
  Misses       50     50           
Files Coverage Δ
...sources/DSC_NetAdapterName/DSC_NetAdapterName.psm1 100% <100%> (ø)
...les/NetworkingDsc.Common/NetworkingDsc.Common.psm1 96% <100%> (+<1%) :arrow_up:

codecov[bot] avatar Apr 24 '23 09:04 codecov[bot]

Hi @nyanhp - sorry I missed this. I'm fixing pipeline and will then review (see #528 ).

PlagueHO avatar Jun 01 '24 00:06 PlagueHO

This PR can be rebased now.

johlju avatar Jun 07 '24 18:06 johlju