NetworkingDsc icon indicating copy to clipboard operation
NetworkingDsc copied to clipboard

Expose -IncludeHidden parameter

Open gaelicWizard opened this issue 3 years ago • 2 comments

Pull Request (PR) description

NetAdapter module Cmdlets have an -IncludeHidden flag which allows access to adapters which are hidden; expose that flag here.

This Pull Request (PR) fixes the following issues

  • Fixes #499: solution 1.

Task list

  • [x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
  • [ ] Resource documentation added/updated in README.md in resource folder.
  • [ ] Resource parameter descriptions added/updated in schema.mof and comment-based help.
  • [ ] Comment-based help added/updated.
  • [ ] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
  • [ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • [ ] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

gaelicWizard avatar May 18 '21 22:05 gaelicWizard

Codecov Report

Merging #495 (7b94cba) into main (983c54b) will increase coverage by 0%. The diff coverage is 96%.

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #495   +/-   ##
===================================
  Coverage    97%    97%           
===================================
  Files        28     28           
  Lines      2070   2071    +1     
===================================
+ Hits       2021   2023    +2     
+ Misses       49     48    -1     
Impacted Files Coverage Δ
...vancedProperty/DSC_NetAdapterAdvancedProperty.psm1 100% <ø> (ø)
...Resources/DSC_NetAdapterRsc/DSC_NetAdapterRsc.psm1 100% <ø> (ø)
source/DSCResources/DSC_NetBios/DSC_NetBios.psm1 97% <ø> (ø)
...s/DSC_WinsServerAddress/DSC_WinsServerAddress.psm1 77% <75%> (ø)
...faultGatewayAddress/DSC_DefaultGatewayAddress.psm1 95% <100%> (ø)
...s/DSC_NetAdapterBinding/DSC_NetAdapterBinding.psm1 98% <100%> (ø)
...Resources/DSC_NetAdapterLso/DSC_NetAdapterLso.psm1 100% <100%> (ø)
...sources/DSC_NetAdapterName/DSC_NetAdapterName.psm1 100% <100%> (ø)
...sources/DSC_NetAdapterRdma/DSC_NetAdapterRdma.psm1 100% <100%> (ø)
...Resources/DSC_NetAdapterRss/DSC_NetAdapterRss.psm1 100% <100%> (ø)
... and 5 more

codecov[bot] avatar May 20 '21 08:05 codecov[bot]

@gaelicWizard - this is quite an interesting one. Could you raise an issue for us to discuss it?

What I'd like to think about (and open for discussion) is should we just switch the -hidden flag on and not bother with the parameter? If you can raise an issue we can get some thoughts on this because I'm trying to find a good reason why if you know the adapter name and want to configure it in some way, why should it matter if it is hidden or not?

PlagueHO avatar May 21 '21 10:05 PlagueHO