ComputerManagementDsc Computer: Remove deletion of AD computer object when using PasswordPass and UnsecuredJoin options or JoinReadOnly option

Pull Request (PR) description

When using PasswordPass and UnsecuredJoin options or JoinReadOnly option means AD computer object has been pre-created within Active Directory prior to domain join and should not be deleted

This Pull Request (PR) fixes the following issues

Fixes #446

Task list

[x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
[x] Resource documentation added/updated in README.md.
[x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
[x] Comment-based help added/updated.
[x] Localization strings added/updated in all localization files as appropriate.
[x] Examples appropriately added/updated.
[x] Unit tests added/updated. See DSC Community Testing Guidelines.
[x] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
[x] New/changed code adheres to DSC Community Style Guidelines.

This change is

May 16 '25 15:05 webalexeu

Walkthrough

The changes modify the DSC_Computer resource to conditionally preserve pre-created Active Directory computer objects when using specific options (PasswordPass and UnsecuredJoin or JoinReadOnly), preventing deletion during domain join operations that expect the object to already exist.

Changes

Cohort / File(s)	Summary
Documentation `CHANGELOG.md`	Added entry documenting that the computer object is no longer deleted when PasswordPass and UnsecuredJoin options or JoinReadOnly option are used (Issue #446).
Resource Logic `source/DSCResources/DSC_Computer/DSC_Computer.psm1`	Introduces conditional logic to detect precreated computer object requirements via `$requiresPrecreated` based on JoinReadOnly or (PasswordPass and UnsecuredJoin) options. When precreation is required and object doesn't exist, raises ObjectNotFoundException. When precreation is not required and object exists, proceeds with deletion. Includes minor comment correction.
Localization `source/DSCResources/DSC_Computer/en-US/DSC_Computer.strings.psd1`	Added new string resource `ComputerObjectNotFound` for localized error message when computer object is not found in domain.

Sequence Diagram(s)

sequenceDiagram
    participant Caller as DSC Configuration
    participant Resource as DSC_Computer<br/>(Set-TargetResource)
    participant AD as Active Directory
    participant Error as Error Handler

    Caller->>Resource: Invoke Set-TargetResource
    
    Note over Resource: Detect precreated requirement<br/>($requiresPrecreated = JoinReadOnly OR<br/>(PasswordPass AND UnsecuredJoin))
    
    Resource->>AD: Query for existing computer object
    alt Object Exists
        alt Precreation NOT Required
            Resource->>AD: Delete computer object
            Resource->>Caller: ✓ Proceed with join
        else Precreation Required
            Resource->>Caller: ✓ Object exists, continue
        end
    else Object Does NOT Exist
        alt Precreation Required
            Resource->>Error: Raise ObjectNotFoundException
            Error->>Caller: ✗ Computer object not found error
        else Precreation NOT Required
            Resource->>Caller: ✓ Proceed (no deletion needed)
        end
    end

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

The changes introduce a new conditional control flow with multiple branches based on precreation detection and object existence, requiring careful verification that the option combinations and error conditions are correct. The logic is focused but depends on accurate interpretation of the PasswordPass, UnsecuredJoin, and JoinReadOnly options.

Pre-merge checks

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title Check	✅ Passed	The title clearly identifies the resource and concisely describes the primary change of preventing deletion of the AD computer object when using the specified options, directly reflecting the main focus of the changeset.
Linked Issues Check	✅ Passed	The changes implement logic to detect and preserve pre-created AD computer objects when using PasswordPass, UnsecuredJoin, or JoinReadOnly options and add corresponding error handling and localization, fully satisfying the objectives of linked issue #446.
Out of Scope Changes Check	✅ Passed	All modifications are confined to adjusting the computer resource behavior for pre-created objects and updating related localization and documentation, with no unrelated or extraneous changes introduced.
Description Check	✅ Passed	The description succinctly explains the rationale behind the change, clarifies that pre-created AD computer objects should not be deleted when using the specified options, and references the related issue, making it clearly relevant to the changeset.
Docstring Coverage	✅ Passed	No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 17e10f3b5c778db2c5cde0848888ca8fbe3af2a5 and 06fe4cbf82abfc3f3eddda461adf215750184a0b.

📒 Files selected for processing (3)

CHANGELOG.md (1 hunks)
source/DSCResources/DSC_Computer/DSC_Computer.psm1 (1 hunks)
source/DSCResources/DSC_Computer/en-US/DSC_Computer.strings.psd1 (1 hunks)

🧰 Additional context used

📓 Path-based instructions (5)

**