ActiveDirectoryDsc icon indicating copy to clipboard operation
ActiveDirectoryDsc copied to clipboard

ADDomain: Fix DNS Delegation issue

Open nanderh opened this issue 5 years ago • 2 comments

Added fix for issue #176 , DNS Delegation not included in ADDomain. And incorporated fix from https://github.com/ansible/ansible/issues/39235

Pull Request (PR) description

Added fix for above issues by:

  • Adding InstallDNS switch if the DnsDelegationCredential option has been used
  • Starting the netlogon service after domain installation

This Pull Request (PR) fixes the following issues

Fixes issue #176 ADDomain: DNS Delegation is no longer working.

Task list

  • [ ] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
  • [ ] Resource documentation added/updated in README.md.
  • [ ] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
  • [ ] Comment-based help added/updated.
  • [x] Localization strings added/updated in all localization files as appropriate.
  • [x] Examples appropriately added/updated.
  • [ ] Unit tests added/updated. See DSC Community Testing Guidelines.
  • [ ] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
  • [x] New/changed code adheres to DSC Community Style Guidelines.

This change is Reviewable

nanderh avatar Nov 25 '20 17:11 nanderh

@nanderh, thanks for your contribution and raising this PR. The CI checks are currently failing for it, as you need to update the changelog, and modify the ADDomain resource unit tests to support this change.

X-Guardian avatar Dec 05 '20 09:12 X-Guardian

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

stale[bot] avatar May 30 '21 13:05 stale[bot]