ActiveDirectoryCSDsc icon indicating copy to clipboard operation
ActiveDirectoryCSDsc copied to clipboard

AdcsAuthorityInformationAccess: Always makes a change #128, #138

Open dan-hughes opened this issue 1 year ago • 5 comments

Pull Request (PR) description

Removed the AllowRestartService parameter from being tested/compared. Updated Get-CaAiaUriList to force a System.String[] to be returned regardless of single or multiple values.

This Pull Request (PR) fixes the following issues

  • Fixes #128
  • Fixes #138

Task list

  • [x] Added an entry under the Unreleased section of the change log in the CHANGELOG.md. Entry should say what was changed, and how that affects users (if applicable).
  • [x] Resource documentation added/updated in README.md in resource folder.
  • [x] Resource parameter descriptions added/updated in schema.mof and comment-based help.
  • [x] Comment-based help added/updated.
  • [x] Localization strings added/updated in all localization files as appropriate.
  • [ ] Examples appropriately added/updated.
  • [ ] Unit tests added/updated. See DSC Resource Testing Guidelines.
  • [ ] Integration tests added/updated (where possible). See DSC Resource Testing Guidelines.
  • [x] New/changed code adheres to DSC Resource Style Guidelines and Best Practices.

This change is Reviewable

dan-hughes avatar Apr 18 '24 15:04 dan-hughes

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98%. Comparing base (60f9961) to head (e9d220b).

Additional details and impacted files

Impacted file tree graph

@@         Coverage Diff         @@
##           main   #141   +/-   ##
===================================
  Coverage    98%    98%           
===================================
  Files         8      8           
  Lines       514    515    +1     
===================================
+ Hits        505    506    +1     
  Misses        9      9           

codecov[bot] avatar Apr 18 '24 15:04 codecov[bot]

@johlju, I looked at this a few weeks ago then found out the build was not working.

It fixes #138 but I also think it may fix #128 as they look to be mentioning the same things.

On tests, I'd need to possibly have mocks with only single AIA and OCSP values in to begin with. Thoughts?

dan-hughes avatar Apr 18 '24 16:04 dan-hughes

If you rebase this one I continue with this one. 🙂

johlju avatar Jun 01 '24 14:06 johlju

I really messed up when trying to merge. I think it's all back to where it should be now.

What's going to be the optimal solution for this? The Get-CaAiaUriList should return a string or string[].

dan-hughes avatar Jun 01 '24 17:06 dan-hughes

I will try to get back to this soon.

johlju avatar Jun 11 '24 17:06 johlju