HeliosLauncher icon indicating copy to clipboard operation
HeliosLauncher copied to clipboard

[Windows] Illegal folder names in modstore stops the launcher root directory from being deleted.

Open Tjmaxmillion opened this issue 1 year ago • 4 comments
trafficstars

The mod Create: Interactive has a folder called aux located at "org\valkyrienskies\create_interactive\aux" in the JAR.

When this mod is moved to the modstore the aux folder ends up there meaning the root directory of the launcher can't be deleted until the aux folder is deleted with the command line.

For a normal user it's unlikely for them to find the aux folder and know this is what is preventing them from deleting the root directory of the launcher. Further I doubt a normal user would know how to use the command line to delete this folder.

Implement something to help with edge cases where Illegal folder/files names are used in jar files?

Image Source image

Tjmaxmillion avatar Feb 28 '24 23:02 Tjmaxmillion

Doesnt this sound like a defect with the mod, and not the launcher?

dscalzi avatar Feb 29 '24 00:02 dscalzi

I don't think the mods creators intended the mods files to be stored outside the JAR file by a user, none the less I did make a issue for the mod too.

But this issue is exclusive to helious because it doesn't store mods in JAR files like other launchers.

Tjmaxmillion avatar Feb 29 '24 00:02 Tjmaxmillion

The launcher does not extract any files from mod jars?

dscalzi avatar Feb 29 '24 01:02 dscalzi

@Tjmaxmillion can I take a look at your distribution file?

GeekCornerGH avatar Feb 29 '24 08:02 GeekCornerGH