connect-compiler icon indicating copy to clipboard operation
connect-compiler copied to clipboard

Hi! I fixed some code for you!

Open node-migrator-bot opened this issue 12 years ago • 4 comments

Hi!

I am migrationBot!

Did you know that path.{exists,existsSync} was moved to fs.{exists,existsSync}, and that tty.setRawMode(mode) was moved to tty.ReadStream#setRawMode() (i.e. process.stdin.setRawMode()) in node v0.8.0? Read more @API changes between v0.6 and v0.8

I automatically made some changes I think will help you migrate your codebase to node v0.8.0, please review these changes and merge them if you feel they are useful, If they are not you can ignore this Pull Request.

Have a Nice Day!

--migrationBot

node-migrator-bot avatar Jul 07 '12 04:07 node-migrator-bot

Won't this break compat with node < 0.8?

dsc avatar Jul 10 '12 13:07 dsc

That is, shouldn't it be: exists = fs.existsSync || path.existsSync ?

dsc avatar Jul 10 '12 13:07 dsc

I'm not sure how to attach a commit to this issue directly. My fix is part of this pull request, and it indeed does as you consider @dsc, it uses (fs.exists || path.exists) to avoid breaking older node versions: https://github.com/dsc/connect-compiler/pull/9 is a pull incorporating the specific commit rektide@57ca095a16cb5e58f684a30c4a9f1d612d9e5083

rektide avatar Jul 24 '12 14:07 rektide

we need this!

ashtuchkin avatar Dec 08 '12 19:12 ashtuchkin