query_reviewer

query_reviewer copied to clipboard

For queries without subqueries (ie: UPDATE), calling SqlQuery#table raises a NoMethodError, since @subqueries is an empty array and [].first returns nil. This happens if such a query triggers a warning...

pivotalneutron

Heya - Rubygems 1.8 deprecated Gem.searcher and got really whiny about it. This patch uses the new Gem::Specification api if it's available.

jdelStrother

Hi! Thanks for making this compatible with rails 3. I love it! I've made a little change, so that on the generated query_reviewer.yml, it sets "enabled=false" for all environments and...

jaimeiniesta

Any chance of a Rails3 port?

10

Right now, if you try to use query reviewer with Rails3, you get the following error: uninitialized constant ActiveRecord::ConnectionAdapters::MysqlAdapter

tatyree

I seem to be getting this error /webapps/ROOT/WEB-INF/vendor/plugins/query_reviewer/lib/query_reviewer/controller_extensions.rb:61:in `process_with_query_review' /appl/sco/tomcat/webapps/ROOT/WEB-INF/gems/gems/actionpack-2.3.5/lib/action_controller/rescue.rb:65:in`call_with_exception' /appl/sco/tomcat/webapps/ROOT/WEB-INF/gems/gems/actionpack-2.3.5/lib/action_controller/dispatcher.rb:90:in `dispatch' /appl/sco/tomcat/webapps/ROOT/WEB-INF/gems/gems/actionpack-2.3.5/lib/action_controller/dispatcher.rb:121:in`_call' /appl/sco/tomcat/webapps/ROOT/WEB-INF/gems/gems/actionpack-2.3.5/lib/action_controller/dispatcher.rb:130:in `build_middleware_stack' /appl/sco/tomcat/webapps/ROOT/WEB-INF/gems/gems/warden-0.10.7/lib/warden/manager.rb:35:in`call' /appl/sco/tomcat/webapps/ROOT/WEB-INF/gems/gems/warden-0.10.7/lib/warden/manager.rb:35:in `call' /appl/sco/tomcat/webapps/ROOT/WEB-INF/gems/gems/warden-0.10.7/lib/warden/manager.rb:34:in`catch' /appl/sco/tomcat/webapps/ROOT/WEB-INF/gems/gems/warden-0.10.7/lib/warden/manager.rb:34:in `call'

suryagaddipati

Hi, If query_reviewer is enabled, it has the 'interesting' side effect of making send_file send 0kb files. This is due to calling 'response.body' in add_query_output_to_view, which then reads the entire...

jdelStrother

doesn't work with ruby 1.9 due to ":" while using "when" in mysql_analyzer.rb

1

changing it to use "then" makes it work .. at least for mysql.

timwee

This is a great gem. I hope for the day when I can use this gem with postgresql 9. The fork I have found that attempts postgresql support: [nofxx fork](https://github.com/nofxx/query_reviewer/commit/b735abe1b00654842a70566147d18cdaf5b31075)...

nesquena