Douglas Blank
Douglas Blank
Down to two categories of pytest errors and failures: 1. vcard related failures 2. 'Test Case Generator' and 'Check & Repair Database' The second one seems like a random number...
@Nick-Hall, this is now ready for review. There is one test that fails, but fails for me in master too. I suspect a change in the random number generator.
@emyoulation, nice catch! Can you turn your above comment into a feature request? I'll handle those issues after this is merged.
@stevenyoungs, I appreciate the review! For the `COLUMN_` suggestions, I decided to go the other way, and remove all of them. I did that for the following reasons: 1. There...
@Nick-Hall, all tests are passing, and I have addressed all review comments so far.
Also, it might be related to the logger. It looks like if I reuse the logger, it keeps add the "openai" tag over and over.
Regarding the traceback, and looking at https://github.com/BerriAI/litellm/blob/main/litellm/integrations/opik/opik.py#L67-L74 It doesn't seem like this is a situation where we should show a traceback, but just info. I don't understand the consequences, but...