David Sanders

Results 118 comments of David Sanders

From your repro video it looks like the files that aren't working are executable files, while those that do are text files. Is that just a coincidence in the video,...

I realize I didn't mention it in the original description, but for full context the GitHub App needed by this PR was set up the other day with @VerteDinde and...

Thanks for the PR, @trajano! 👍 While we appreciate the effort, I'm not sure adding example output on Windows adds anything meaningful to the docs. As such, I'm going to...

Looks like the current behavior was introduced in [v20.2.0](https://github.com/electron/electron/releases/tag/v20.2.0). Looks like it's likely an upstream Chromium change that introduced it.

> Bikeshed of `blinkUtils` namespace I'm not in API WG but my 2 cents on the namespace would be not including blink since that feels a bit too internal/unnecessary detail...

Thanks @varunsood2003! I've tweaked the PR description (release notes are not needed for documentation changes) and overall things LGTM now. 👍 cc @electron/docs

Thanks for the PR @astone123! There's actually a few broken Apple docs links (according to `yarn run lint:docs-relative-links --fetch-external-links`) - any chance you'd like to expand this PR to fix...

Hi @ashutosh887! I'm already working on this, but thank you for the interest. 🙂

@ashutosh887, I'm not currently aware of any that are good for new contributors, but you could check the https://github.com/electron/electron/labels/beginner%20friendly label. If you'd like to work an issue, as long as...