David Sanders

Results 117 comments of David Sanders

Apparently Dependabot has forsaken this PR. 🤷

I've also run into this issue and I think I have a reproduce case with the config @stevvooe provides. I got the same error after upgrading to v2.2.1 from v2.1.1,...

> So any PRs are welcome. I'll probably make some PRs over the next few months. It's a low priority need for me, but it's one I'd like to get...

Alright, sounds good to me.

Tests appear to be failing on Windows.

Is `api-review/reviewed` a new label that's been created recently? It's not one of the labels that cation knows about. https://github.com/electron/cation/blob/b5ea25ad6ebfb0f4faa3169089d94ea9c228bdb6/src/constants.ts#L37-L41 cation doesn't let humans modify those labels on a PR,...

I think the possibility to localize the text is a reasonable feature, and should probably be supported without requiring users to re-implement the dialog all together. For customizing the dialog...

> When we create the dialog, we pick the dialog API from electron in the options It looks like this is just an undocumented option for testing purposes (I'm not...

> I don't think letting users specify the capabilities makes sense. Perhaps if this was a CLI or other end-user targeting project, but isn't this a library for developers to...