vagrant-ansible icon indicating copy to clipboard operation
vagrant-ansible copied to clipboard

Incompatibility with Vagrant 1.1.x

Open command-tab opened this issue 11 years ago • 14 comments

The plugin format for Vagrant 1.1.x has changed, rendering vagrant-ansible broken. Are there plans to update it? If not, I might take a crack at it (even with my limited Ruby skills).

command-tab avatar Mar 15 '13 22:03 command-tab

+1

mbadran avatar Mar 17 '13 10:03 mbadran

+1

I have made an effort to port the plugin to 1.1 and it's really close to be finished. Unfortunately I have basically no Ruby knowledge, I have used the documentation and the other provisioning plugins as a base. If you would find it useful, I could at least make a pull req with what I have.

cvitan avatar Mar 18 '13 11:03 cvitan

@cvitan I'd be interested in putting your code through its paces — I've got some Ansible scripts to work on and would like to continue using Vagrant 1.1 with VMware. I don't see it yet in your vagrant-ansible fork.

command-tab avatar Mar 18 '13 15:03 command-tab

@commandtab Sure, I'll just clean it up a bit and push it as soon as I have time, have made some further progress still.

cvitan avatar Mar 18 '13 15:03 cvitan

gem sub-command was also renamed, ('plugin' now?), So need new installation instructions as well.

emckenna avatar Mar 18 '13 20:03 emckenna

I got: Message: uninitialized constant Vagrant::Provisioners::Base after successful vagrant plugin install vagrant-ansible. Is it large change to make ansimble plugin compatible with 1.1?

AlexMikhalev avatar Mar 21 '13 16:03 AlexMikhalev

I wrote a new Vagrant plugin for 1.1.x that does most of what vagrant-ansible does:

https://github.com/mitchellh/vagrant/pull/1465 https://github.com/hashicorp/docs.vagrantup.com/pull/10

The only thing it doesn't do is the temporary inventory file, because using it stops group_vars and host_vars from working, which are (more often than not) very important for playbooks. Looking for feedback :) Hopefully this will get pulled into Vagrant core.

command-tab avatar Mar 21 '13 16:03 command-tab

@commandtab Looks awesome! And merging it into Vagrant core is the way to go.

Please vote: mitchellh/vagrant#1465

mbadran avatar Mar 21 '13 22:03 mbadran

Well done! Maybe it would be a good idea to serve it as an installable plugin until then?

cvitan avatar Mar 23 '13 10:03 cvitan

Is this fixed by the release of mitchellh/vagrant#1465?

garethrees avatar Apr 22 '13 12:04 garethrees

@dsander maybe you can mention DEPRECATED in the repo title, or rename it, or something? As its now part of vagrant core, people finding this repo can lose lots of time wondering why it doesn't work...

Thanks for leading the way with this plugin!

dch avatar Aug 27 '13 22:08 dch

@dch thanks for the heads up. I updated the README, can you please confirm the documentation link is valid?

dsander avatar Aug 27 '13 23:08 dsander

oh my god, I just spent like hours, between several sessions of trying to figure out why Ansible was working on one machine and not on another. Turns out, adding this plugin actually breaks Vagrant 1.3+, since it's already built in. Now I feel stupid.

But perhaps someone can avoid the same fate as me.

milojennings avatar Sep 30 '13 03:09 milojennings

@dsander, perfect!

dch avatar Sep 30 '13 11:09 dch