dsa-t

Results 141 comments of dsa-t

>Would it make sense to extract this into a (private) function to make it easier to change this later, if necessary? Not sure what would be the right place to...

Sounds ok to me, I probably won't have time to tackle it though.

Also added patches for building wx for Android via CMake. This way I don't have to use patchelf tricks to remove .so versioning suffixes (Android requires shared library names to...

> @dsa-t Do you plan to simplify CMake logic as proposed? Yes, I'll check it.

`FindThreads.cmake`'s test fails because Android doesn't implement `pthread_cancel`: Error log ``` Performing C SOURCE FILE Test CMAKE_HAVE_LIBC_PTHREAD failed with the following output: Change Dir: ${builddir}/CMakeFiles/CMakeScratch/TryCompile-ubkGdg Run Build Command(s):/usr/bin/gmake -f Makefile...

I also agree that it's better to use `${CMAKE_THREAD_LIBS_INIT}` instead of `"-pthread"`, and some `if` checks can be removed, However I wanted to keep changes in this PR to a...

>Could you perhaps make a separate PR with these changes and then rebase this on top of it? This is for @MaartenBent I assume? I'm not building with Win32/Clang to...

> not use CMAKE_HAVE_LIBC_PTHREAD because it is an undocumented output from FindThreads I didn't really think this is a problem but ok. Another idea is to provide a custom `FindThreads.cmake`...