Panilla icon indicating copy to clipboard operation
Panilla copied to clipboard

Creative crash with chest loop

Open Malachiel87 opened this issue 4 years ago • 17 comments

Hi i am using 1.15.2 and server crash when a player using a hack for generate chest inside chest ecc i attached the playerdata of the hacker db99c79e-4380-453d-88f9-44b531dc206c.zip

Malachiel87 avatar Aug 27 '20 08:08 Malachiel87

Is there a server crash? I believe this would crash (or slow down significantly) a client's connection, but the server should stay running with little to no performance impact.

The reason for this is the server, asynchronously, has to send large amounts of data to the clients requesting the contents of the chests. It does not impact the actual server performance because, again, it's not run on the main server thread; it is run async.

I can look at improving the detection of these items. However, in my opinion, they are relatively harmless. Especially because they don't cause a "crash" rather a timeout in rare cases where too many requests have been made to the server.

ds58 avatar Aug 27 '20 14:08 ds58

yeah there was a crash and people are unable to join the server for nbt errors Server log: https://gist.github.com/xion87/6846938fb5228e1e5f2123ae9e2231fa

Malachiel87 avatar Aug 27 '20 15:08 Malachiel87

Thanks for the log. I'll look into it

ds58 avatar Aug 27 '20 15:08 ds58

Seems like the plugin CMI is doing something with the chests causing the server to hang. This isn't too surprising as the chests do contain a lot of data.

ds58 avatar Aug 27 '20 15:08 ds58

I will look into creating a check for these types of situations where the items don't necessary have "hacked" NBT tags, nor do they crash clients, but can inherently cause issues with plugins manipulating them.

ds58 avatar Aug 27 '20 15:08 ds58

so is can cmi is trying to save all data on INVSEE inventory?

Malachiel87 avatar Aug 27 '20 15:08 Malachiel87

I am not sure what CMI is doing with the items but it is the reason the server froze.

ds58 avatar Aug 27 '20 15:08 ds58

got another crashed image image image

Malachiel87 avatar Aug 27 '20 18:08 Malachiel87

All these chest/skuller are filled with these items

Malachiel87 avatar Aug 27 '20 18:08 Malachiel87

any news? people are abusing this....

Malachiel87 avatar Sep 24 '20 17:09 Malachiel87

the fun thing that i have also banitem with a check that prevent chest to be put inside to any container and people are still able to do that

Malachiel87 avatar Sep 24 '20 17:09 Malachiel87

CMI seems to be the reason the server is freezing. I don't have a solution to prevent this yet

ds58 avatar Sep 24 '20 18:09 ds58

It may be worth trying this latest build as I introduced some changes which may help. Won't guarantee it, however.

panilla-1.6.0-pre1.zip

ds58 avatar Oct 27 '20 17:10 ds58

did you report this to CMI? what exactly is CMI doing?

ScuroK avatar Oct 29 '20 22:10 ScuroK

is not a cmi issue, having more crasher in these day, i have upgraded to 1.16.4. the crasher have these chest image He have 4-5 chest filled witht these chest too, and nametags with the same weird name, any way?

Malachiel87 avatar Jan 13 '21 16:01 Malachiel87

Itemfixer option from exploitfixer work fine, but it block also skulls too sadly

Malachiel87 avatar Jan 13 '21 16:01 Malachiel87

Issue still not fixed, it crash with these logs 2021-02-15-3.zip Using latest paper 1.16.5 and panilla 1.6.4

Malachiel87 avatar Feb 18 '21 08:02 Malachiel87

Please reopen if this is still an issue. I am doing issue cleanup.

ds58 avatar May 25 '23 22:05 ds58