ecole icon indicating copy to clipboard operation
ecole copied to clipboard

Getting unreasonably large values for the Khalil feature rows_neg_coefs_mean

Open SelinBayramoglu opened this issue 2 years ago • 3 comments

Hello,

When extracting Khalil2016 features for the attached instance, I get very large positive values for the rows_neg_coefs_mean feature (feature id: 14) such as 1.15292150e+18. As a result, rows_neg_coefs_stddev (feature id: 15) has values on the same order.

Describe the bug

instance_1.lp.txt

Setting

  • OS: Linux
  • Python version: 3.9.12
  • Ecole version: 0.8.1

To Reproduce

After renaming the instance file to "instance_1.lp", place it in your working directory and run the following script: `import ecole env = ecole.environment.Branching(observation_function=ecole.observation.Khalil2016()) env.seed(0)

filename = "instance_1.lp"

observation, action_set, _, done, _ = env.reset(filename) while not done: var_feats = observation.features print(var_feats[:,14]) break`

Expected behavior

I expect negative values for rows_neg_coefs_mean of much smaller magnitude

SelinBayramoglu avatar Mar 11 '23 21:03 SelinBayramoglu

The same bug happens when i use the Khalil feature.

stardustwls avatar Mar 19 '23 12:03 stardustwls

I found the same issue when use the code. The Khali features have 72 dimensions in total. However, I found the dimensions from 48 to 65 can usually be either np.inf or np.nan.

Yufei-Kuang avatar Jun 14 '23 13:06 Yufei-Kuang

This bug might have been fixed by #343, which was merged in the master branch. Unfortunately these changes are not present in the latest stable release, there is a bunch of stuff that has been refactored in master and have not been tested thoroughly.

I suggest two options, which both require to install from source (see instructions here):

  • checkout and install directly from master
  • checkout the current stable Ecole version (v0.8.1), then cherry-pick this specific commit and install from source

I'm sorry this comes a bit late and I can't offer further assistance. Hope it helps anyway

gasse avatar Sep 11 '23 15:09 gasse