patch-package
patch-package copied to clipboard
ds300
Error does not result in non-zero exit code
$ ./node_modules/patch-package/index.js
patch-package 6.2.2
Applying patches...
[email protected] ✔
ethereumjs-abi/[email protected] ✔
ethereumjs-tx/[email protected] ✔
[email protected] ✔
[email protected] ✔
Error: Patch file found for package keccak which is not present at node_modules/web3-provider-engine/node_modules/keccak
results in exit code zero
this should report a non-zero exit code
related https://github.com/ds300/patch-package/issues/210
looks like it is intentional https://github.com/ds300/patch-package/issues/86
workaround is NODE_ENV=test
Unbelievable, that ignoring an error is actually intended - I've just struggled with strange errors in a project, because I wasn't aware of a patch not being applied.
If yarn leaves the working directory in an inconsistent state after postinstall script failure, it's yarn's issue.
I understand why running this local ends in a zero exit code, but is there anything we can do so it outputs to the yarn install log?
