ds-sloth
ds-sloth
Ah, I see. I had been imagining it would be done automatically. Yes, if we add the necessary settings UI so that a user can manually specify per-character controls profiles,...
It seems to me that this is not a bug exactly but a vanilla peculiarity resulting from the poor documentation of these two NPC flags. In the source code there...
If it's only modifying a PlaySound call, I think it's reasonable to not make any compat flag for this, or possibly just guard it behind the new Modern SFX config...
If we're modifying the death logic then it will require a compat flag, and I'm not sure if this is an important enough change to add one.
Then, I think we agree with each other on this point. As long as the only death logic we are improving is sound-related, it's fine.
This should be fixed now -- I'm sorry for the very long wait. Can you please confirm?
Hi, this looks like an interesting use case! I see one problem here, in `multitrackplayer::stop()`. It is illegal to call `Mix_FreeMusic(music)` if `music` is currently playing. The null dereference is...
That's a good point; I wasn't aware of that part of the specification and have never personally relied on this behavior. It's good for the library to try its best...
It may also be interesting to snap the editor cursor to a grid when a controller is used. (Suggested by Mr Mustache on Discord.)
I'd personally want to see some way to disable this (though that'd depend a bit on the mission of X2 which the community will hopefully think through in the coming...