Raphaël Droz

Results 388 comments of Raphaël Droz

AFAICT The only real issue is handling "aux". 1. Modifying every function prototype is intrusive and not good in the long-run. 1. Having a class is the way to go....

I couldn't find the (public?) branch with the refactor.

I gave it a quick look but it sounds that the merge conflicts more than what my mind is able to remember regarding this PR. Sorry.

If [@humanmade](https://github.com/humanmade/Wordpress-Importer) had merged the PR and let feature/bugfix contributions in (instead of just freezing the project without affording even one hour a week to review), then less companies would...

Errors during rebuilding resources may be related to https://github.com/iBotPeaches/Apktool/issues/3534 One way to know more about this is to interrupt the process and run `apktool -v build` (I wish `apk-mitm` could...

Aside from the specific of #3786, and talk about sentence garbage : 1. I wanted to use this issue to call the attention of @Gregoor (added the 2M+ sentences from...

Ok so there are two problems are stake here: 1. Existing filtering logic is broken (at least for French). I commented in https://github.com/common-voice/commonvoice-fr/pull/50#discussion_r1152697185. @MichaelKohler : The presence of **some** symbols...

> However, just to make sure there is no misunderstanding: even if you delete existing sentences, we will need to make sure that we only have a maximum of 3...