dry-view icon indicating copy to clipboard operation
dry-view copied to clipboard

Deprecation warnings from dry-configurable

Open ZimbiX opened this issue 3 years ago • 7 comments

I'm seeing warnings, as it appears dry-configurable deprecated a couple of things without dry-view having been updated.

/usr/local/bundle/ruby/2.7.0/gems/dry-view-0.7.1/lib/dry/view.rb:36:in `<module:Dry>' [dry-configurable] default value as positional argument to settings is deprecated and will be removed in the next major version
Provide a `default:` keyword argument instead

/usr/local/bundle/ruby/2.7.0/gems/dry-view-0.7.1/lib/dry/view.rb:36:in `<module:Dry>' [dry-configurable] passing a constructor as a block is deprecated and will be removed in the next major version
Provide a `constructor:` keyword argument instead

For the latter, keyword arguments are now needed instead of passing a block, e.g. here

ZimbiX avatar Feb 08 '22 07:02 ZimbiX

Hey @ZimbiX! dry-view development has essentially moved over to hanami/view, but I'd be more than happy to cut a release with these dry-configurable deprecations addressed, if you're OK to submit a PR here based on https://github.com/hanami/view/pull/190 😄

timriley avatar Feb 09 '22 12:02 timriley

Hiya @timriley =) Ah ha; thanks for the heads up. The changes do look straightforward, and I did consider making them myself. But if this isn't going to keep up with future changes in dry-rb, it might be better that we switch. Hmm, I'll look into it and have a think about what would be the best approach for us.

Thanks for all your work!

ZimbiX avatar Feb 09 '22 14:02 ZimbiX

@timriley please have a look - https://github.com/dry-rb/dry-view/pull/153

olegykz avatar Jul 27 '22 09:07 olegykz