dry-validation icon indicating copy to clipboard operation
dry-validation copied to clipboard

Update config in configure blocks only

Open timriley opened this issue 1 year ago • 4 comments

Update all usages of dry-configurable-provided config so that any changes are made inside configure blocks.

This prepares for the changes in https://github.com/dry-rb/dry-configurable/pull/140.

timriley avatar Sep 22 '22 20:09 timriley

I'm sorry but can this only include configure change? I don't want zeitwerk stuff to be in the main branch just yet. It's not ready (dry-core is not released) and it already caused two invalid releases of dry-schema (which is why I reverted zeitwerk changes in its main branch).

solnic avatar Sep 23 '22 08:09 solnic

@solnic Yep, I can do this. Weirdly, dry-configurable in the main branch has already been updated to expect the Zeitwerk-enabled dry-core, which is why all these gems I'm testing with dry-configurable also need dry-core updated.

Do we want to keep zeitwerk-enabled dry-core? What is our plan for Zeitwerk in our other gems pre-1.0? Because I want to bring everything to 1.0 (at least as release candidates) basically in the next month.

timriley avatar Sep 23 '22 11:09 timriley

What I'll do for starters is just revert the commit in dry-configurable's main branch that expects the zeitwerk-enabled dry-core.

timriley avatar Sep 23 '22 11:09 timriley

@solnic FYI, with https://github.com/dry-rb/dry-configurable/pull/142 now merged, I've updated this branch so it is no longer changing anything related to requiring code.

timriley avatar Sep 24 '22 06:09 timriley