openapi-typescript icon indicating copy to clipboard operation
openapi-typescript copied to clipboard

bump openapi-typescript-fetch version

Open ajaishankar opened this issue 1 year ago • 1 comments

Changes

Bumps the version of openapi-typescript-fetch for benchmark

How to Review

No code changes, all tests should pass

Checklist

  • [ ] Unit tests updated
  • [ ] docs/ updated (if necessary)
  • [ ] pnpm run update:examples run (only applicable for openapi-typescript)

ajaishankar avatar Apr 29 '24 05:04 ajaishankar

⚠️ No Changeset found

Latest commit: 39a0cc32a340d0a5866eb44a00ead06863b1cea2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Apr 29 '24 05:04 changeset-bot[bot]

Thanks!

Was looking into the Hono framework and they use Mitata for their benchmarks

Not sure if it would make a difference.

Feel the benchmark tests should exercise more functionality like request/response serialization and middleware.

That would be a better comparison.

Sorry have not got a chance to look into adding those...

btw you might find their RPC strongly typed client/server implementation interesting...

ajaishankar avatar May 09 '24 03:05 ajaishankar

Will take a look at Mitata! Probably anything will be an improvement over Vitest’s benchmarks.

btw you might find their RPC strongly typed client/server implementation interesting...

Oh that’s interesting! It looks like it uses Zod, which I personally wouldn’t want to use in this project because of the weight/runtime cost. But I’m sure in the inference piping it’s doing, there are probably some interesting ideas worth looking into. Good suggestion!

drwpow avatar May 09 '24 04:05 drwpow