Andrew W. Lee

Results 145 comments of Andrew W. Lee

Sorry for the delay, but I've had a chance to dive in a bit deeper. On the POC, I think the motivations make sense. If I'm understanding it correctly, it's...

> So I'm dumping my branch, glad that you mentioned it, otherwise I would have put more time to wrap it up as PR ๐Ÿ‘ First off, I appreciate the...

Hi @carldr, thanks so much for submitting a PR. I think the changes make sense to me, I'm going to spend a bit more time thinking through the separate associations...

I'm doing a clean up of the project PRs and issues. Closing this for now as it's a bit stale. Feel free to re-open if/when you get around to this....

Thank you for submitting a PR! It's very much appreciated. Could you add test case or provide an example of the comment length intefering with the annotations?

@shibaaaa PRใฏใ‚ใ‚ŠใŒใจใ†๏ผใ‚‚ใ†ๆ•™ใˆใฆใใ ใ•ใ„ใ€‚ใƒ†ใ‚นใƒˆใจใ‹ไพ‹ใŠ้ก˜ใ„ใ—ใพใ™ใ€‚ ไปŠๆ—ฅๆœฌ่ชžใ‚’ๅ‹‰ๅผทใ—ใฆใ‚‹ใ‘ใฉใ€้–“้•ใ„ใŒใ™ใฟใพใ›ใ‚“ใ€‚

For any future reader, the change looks like this: Before (with `--without-column-comments`): ```ruby # == Schema Information # # Table name: commented_models(table comment) # # id :bigint not null, primary...

Sorry for the delay, I recently started a new job and haven't been able to spend time to fully review the PR. This looks good to me, thank you for...

ไป•ไบ‹ใฎๅพŒใงๆ–ฐใ—ใ€Œreleaseใ€ใ‚’ไฝœใ‚‹ใ€‚

@Z2Flow thanks for submitting a detailed issue. I think the request makes sense. I'll have some time to take a look at this on my Friday.