annotaterb icon indicating copy to clipboard operation
annotaterb copied to clipboard

Support the glob pattern in `root_dir` and `model_dir`

Open sinsoku opened this issue 10 months ago • 4 comments

We often want to specify multiple directories in root_dir and model_dir. For example, when using engines, packs-rails, etc.

  • https://github.com/rubyatscale/packs-rails
  • https://guides.rubyonrails.org/engines.html

This commit supports the glob pattern with these options, making it easy to specify multiple directories.

fixes #99

sinsoku avatar Feb 27 '25 00:02 sinsoku

@drwl CI failed, so I fixed Style/StringLiterals and force-pushed.

sinsoku avatar Mar 03 '25 06:03 sinsoku

@sinsoku just checking -- have you been able to try these changes in your local? I don't have a Rails app with packwerk setup to test.

drwl avatar Apr 05 '25 22:04 drwl

@drwl I have tested it in a Rails app using packwerk. It worked with this change.

sinsoku avatar Apr 14 '25 02:04 sinsoku

Also successfully tested this in a large Packwerked application. Thank you both for the contributions here!

jarredhawkins avatar May 03 '25 00:05 jarredhawkins

Thanks for the confirmations @sinsoku and @jarredhawkins .

drwl avatar May 30 '25 19:05 drwl