David Wells
David Wells
Sorry for the slow responses - I'll get back to this on Friday. I know it is a lot but I'd like to start writing things in a more generic...
If we're going to make a big change like this we should just incompatibly change the interface to be better. That would be another reason to wait until after June...
This looks good but I'm hesitant to make such a sweeping change right before the release. Are you OK with holding off on this until we create a release branch?
Yup (and it shouldn't). It would be better to replace these pointers with references, but one thing at a time.
Lets do one more release and then switch to requiring C++17.
@nayaksagar Can you make the suggested changes? It would be great to get this in for the next release (which is due out by the end of the month).
@amneetb is this ready?
Something to add here is documentation on how to handle paraview support. We got this shell script on the mailing list: ```sh #!/bin/bash VizPath="./viz_IB3d_$1/*/" #data folder path OutFileName="./viz_IB3d_$1/paraview.samrai.series" #output file...
See also #1642 for some more things which could be better documented.
Another long-term thing to think about (related to this) is that we need some more IBAMR developers. There are a bunch of outstanding PRs - we all only have so...