David Wells
David Wells
We already check for availability of `[[deprecated]]` and `[[deprecated("msg")]]` via ```cpp #if defined(__has_cpp_attribute) #if __has_cpp_attribute(deprecated) #define IBTK_DEPRECATED(msg) [[deprecated(msg)]] #else #define IBTK_DEPRECATED(msg) [[deprecated]] #endif #else #define IBTK_DEPRECATED(msg) #endif ``` so that...
Lets handle this after the release. At that point we can bump the minimum supported C++ dialect which will clean this (and a lot of other things) up.
There's something screwy going on with how our config file shims are defined for autotools: ``` 2023-05-13T15:12:21.5775972Z In file included from ../../../tests/IBTK/version_macros.cpp:14: 2023-05-13T15:12:21.5776419Z ../../../include/ibamr/config.h:38:67: error: missing binary operator before token...
> Are there any other outstanding issues with the library code of this PR? Good question - I'll scan through this PR this afternoon and list anything I spot. Boyce...
There's about 15,000 lines of code now in this PR - by comparison there are 12,000 lines in the deal.II reimplementation of `IBFEMethod/IBFESurfaceMethod`. I'm going to need a few more...
I'm a bit late to the party this morning! > I think it will be better to work directly with https://github.com/IBAMR/IBAMR/pull/1570. If you can break and stitch them together soon...
In particular, we can put the phase-change stuff in another repository - I can help you set it up if you think that will solve your present problems. That gives...
I don't think that will work since we need a `Manifold` and that can't work for some manifolds, like `TransfiniteInterpolationManifold`.
It's beyond the scope of this PR, but I'm curious - how hard would it be for us to add a `MatrixBase` class which implements `MatrixBase::add()` and `MatrixBase::compress()`? It would...
Would this also fix #331?