David Wells

Results 329 comments of David Wells

My concern is code like https://github.com/IBAMR/IBAMR/blob/master/examples/IBFE/explicit/ex5/example.cpp#L638, where specifically ```cpp System& X_system = equation_systems->get_system(IBFEMethod::COORDS_SYSTEM_NAME); System& U_system = equation_systems->get_system(IBFEMethod::VELOCITY_SYSTEM_NAME); NumericVector* X_vec = X_system.solution.get(); ``` i.e., we expect that we can extract data...

If you think it will work and be backwards compatible then lets go ahead and do it. I also think inheriting from IBFEMethod would also solve this problem. I feel...

This is probably a bad idea but I'm willing to throw it into this conversation in case the system name refactoring ends up being harder than we expect - if...

Fortunately we can skip reimplementing absolutely everything in IBFEMethod - there is a bunch of stuff (like spreading transmission forces) that we know is a bad idea. My tentative plan...

I have updates. I spent about three weeks implementing the deal.II version of IBFE described above with IBFE/explicit/ex4 working here: https://github.com/drwells/fiddle/blob/master/tests/interaction/ifed_ex4.cc We'll talk about this more next week, but a...

Nice work. I am heading out of town until Monday so I will look at this next week!

Not yet - I only got back from camping last night. I'll get through this today or tomorrow.

Only sometimes. I took a pretty big shortcut early on when writing tests of adding a lot of tests based on example programs, but more recently they are more like...

I have answers to https://github.com/IBAMR/IBAMR/pull/1307#issuecomment-884406720: - attest sets the test name equal to everything before the first period. There are a bunch of other pieces of information about tests that...

We are still missing 57 tests - attest can find 431 tests, but ctest only has 374. One problem that I don't know how to fix with ctest is scheduling...