ng2-scroll-to icon indicating copy to clipboard operation
ng2-scroll-to copied to clipboard

Out-of-date dependencies

Open adama357 opened this issue 7 years ago • 2 comments

Every time I pull packages for my Angular 4 project, I get these errors:

warning "[email protected]" has incorrect peer dependency "@angular/core@^2.4.0".
warning "[email protected]" has incorrect peer dependency "@angular/common@^2.4.0".
warning "[email protected]" has incorrect peer dependency "@angular/compiler@^2.4.5".
warning "[email protected]" has incorrect peer dependency "@angular/platform-browser@^2.4.5".
warning "[email protected]" has incorrect peer dependency "@angular/router@^3.2.0".
warning "[email protected]" has incorrect peer dependency "zone.js@^0.7.2".

As far as I can tell, all is still working correctly; it would just be nice to have this fixed at some point or another.

(Plus, probably rename it to simply ng-scroll-to, since it's just angular.)

Thank you for your time!

adama357 avatar Nov 08 '17 16:11 adama357

We replaced this non-maintained lib with https://www.npmjs.com/package/ngx-page-scroll

jakubjosef avatar Jul 09 '18 12:07 jakubjosef

Thank you for your reply. Unfortunately, after trying out ngx-page-scroll, we'll probably stick with using ng2-scroll-to for now, because:

(1) the performance is better: ngx-page-scroll has a low frame rate if there are many items on a page, while ng2-scroll-to runs smoothly on the same page, and

(2) ng2-scroll-to gives you ease-in-ease-out by default. While ngx-page-scroll gives you the option to add custom easing logic, the documentation doesn't give any guidance as to how to implement this logic.

adama357 avatar Jul 10 '18 15:07 adama357