drush icon indicating copy to clipboard operation
drush copied to clipboard

Potential changes as it will soon be possible for themes to declare dependencies on modules.

Open bbenjamin opened this issue 6 years ago • 2 comments

After roughly a decade, this issue has been escalated to critical and may actually see completion in the near future. https://www.drupal.org/project/drupal/issues/474684

In my most recent patch at the time of writing this (#206), I made some changes to \Drupal\Core\Extension\ModuleHandler::buildModuleDependencies that prevent uninstalling modules that enabled themes depend on. The experience is not great at the moment - Drush will output an error rather than useful information about the dependencies.

It seems like changes might be needed on Drush's end to provide useful output when a user attempts to disable a module depended-upon by an enabled theme. I'd like to make sure I implement this in a way that ensures it works well with Drush. Please weigh in on that issue if there's anything you'd like considered in that feature's implementation.

bbenjamin avatar Nov 06 '19 19:11 bbenjamin

This got in! A backward compatible Drush PR is welcome.

weitzman avatar Apr 07 '20 02:04 weitzman

I mentioned this issue in https://www.drupal.org/project/gitlab_templates/issues/3487335 as I think it will be more beneficial to do it here instead.

I guess it can go behind a flag like --enable-dependencies or we can just simply enable them like it's done in drush pm:enable -y.

fjgarlin avatar Nov 18 '24 19:11 fjgarlin