drush icon indicating copy to clipboard operation
drush copied to clipboard

Uid mail sanitisation whitelist

Open miloskroulik opened this issue 5 years ago • 3 comments

This adds mail and uid based whitelist for SQL sanitization, as described in #3756 The test are running fine, but it's likely that PR still has some issues, because it's my first Drush patch.

miloskroulik avatar Oct 09 '19 12:10 miloskroulik

It seems that the test failure is related to some test which is not part of the functional testsuite I can run locally. I'm not sure how to proceed.

$ docker-compose exec drupal composer functional
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
> composer phpunit -- --testsuite functional
You are running composer with xdebug enabled. This has a major impact on runtime performance. See https://getcomposer.org/xdebug
> php -d sendmail_path='true' vendor/bin/phpunit --colors=always --configuration tests '--testsuite' 'functional'
PHPUnit 6.5.14 by Sebastian Bergmann and contributors.

..............................S....................S..            54 / 54 (100%)

Time: 15.53 minutes, Memory: 12.00MB

OK, but incomplete, skipped, or risky tests!
Tests: 54, Assertions: 279, Skipped: 2.

miloskroulik avatar Oct 11 '19 19:10 miloskroulik

@weitzman I hope that I addressed all your findings.

miloskroulik avatar Feb 12 '20 13:02 miloskroulik

The whitelist term seems to be deprecated and changed to allowlist: https://www.drush.org/latest/commands/sql_sanitize/

MartijnCuppens avatar Nov 24 '21 10:11 MartijnCuppens