drupal-scaffold icon indicating copy to clipboard operation
drupal-scaffold copied to clipboard

Plugin::scaffold call is deprecated but README says it should be added to post-install commands

Open aaleksu opened this issue 4 years ago • 5 comments

How is that possible that in 2.6.1 version in README you say that post-install-cmd should be adjusted with "DrupalComposer\DrupalScaffold\Plugn::scaffold()", but Plugin::scaffold method has this as its first line: https://github.com/drupal-composer/drupal-scaffold/blob/2.6.1/src/Plugin.php#L96?

aaleksu avatar Sep 17 '20 18:09 aaleksu

Oh, if I had to guess I'd say that the README is out of date, but I don't really remember the fine details of this project, the entirety of which is deprecated.

Everyone should move to drupal/core-composer-scaffold. It is recommended, supported, and more performant, not to mention works with Drupal 9 and Composer 2.

greg-1-anderson avatar Sep 17 '20 19:09 greg-1-anderson

@greg-1-anderson is right. You should look at drupal/core-composer-scaffold. I skimmed through the README and could not find the part you mentioned about post-install-cmd.

webflo avatar Sep 17 '20 20:09 webflo

I updated the README to advise that this project is deprecated.

greg-1-anderson avatar Sep 17 '20 20:09 greg-1-anderson

Thanks @greg-1-anderson. Could you elaborate a bit on the "everyone should move to drupal/core-composer-scaffold" part? What do I need to do to make the switch? Is is required to move to core-composer-scaffold when I upgrade my site to D9?

marcvangend avatar Oct 05 '20 09:10 marcvangend

Yes, drupal-composer/drupal-scaffold will not support Drupal 9 or Composer 2, so everyone will have to switch.

greg-1-anderson avatar Oct 05 '20 15:10 greg-1-anderson