drupal-project icon indicating copy to clipboard operation
drupal-project copied to clipboard

Set minimum-stability to "stable"

Open rodrigoaguilera opened this issue 7 years ago • 7 comments

Currently minimum-stability is set to "dev". I think we should rely on composer defaults and have the minimum stability set to "stable" just by removing that line. https://getcomposer.org/doc/04-schema.md#minimum-stability

Then we will need to add dev, alpha, beta, RC suffixes to the specific dependencies that need it like for example devel or drupal console. https://getcomposer.org/doc/04-schema.md#package-links The composer.json get also more semantic.

This way we don't hide dependencies on modules, libraries, etc that are not so mature.

This all started for me because there is a contrib module with a broken HEAD https://www.drupal.org/node/2872222

What do you think?

rodrigoaguilera avatar Apr 25 '17 17:04 rodrigoaguilera

This should not happen we use "minimum-stability": "dev" and "prefer-stable": true for this reason. Are you sure you have both in your composer.json?

webflo avatar May 05 '17 23:05 webflo

I think they fixed superfish module now but I will try to publish a dummy library to reproduce this.

Anyway that problem is not the main reason for this change. Is about making dev,beta, alpha and rc dependencies more explicit instead of saying pick any stability but prefer stable.

I feel we also get a speed improvement since less releases are scanned.

rodrigoaguilera avatar May 06 '17 08:05 rodrigoaguilera

+1 on this. It's safer and faster to specify the stability on a per package level.

slootjes avatar Aug 14 '17 06:08 slootjes

With drupal console stable now the template doesn't even has to specify any stability.

We can add devel as an example that is going to need a @RC tag if "minimum-stability": "dev" is removed

rodrigoaguilera avatar Aug 14 '17 06:08 rodrigoaguilera

Seems like core is grappling with this at the moment too: https://www.drupal.org/project/drupal/issues/3135247

joelpittet avatar Jun 16 '20 23:06 joelpittet

Core indeed moved to stable now (9.1.0). The change record contains a lot of good arguments to do the same. Then the README needs to be updated to explain how to properly require unstable releases.

normanlolx avatar Jan 12 '21 22:01 normanlolx

I'm on board with this too now, you can be explicit about your @dev if you need the unstable.

joelpittet avatar Feb 20 '21 00:02 joelpittet