Intention behind R_VR Command Execution

[patrick-gaertner]

Servus,

I shortly want to ask if their is a technical reason about the implementation of the R_VR (read software version) command. Because the Lib uses additional Bytes which are not documented in the LSV2 Protocol File (F!!!-Heidenhein)

The additonal Bytes are working fine fpr iTNC530 and newer but I am currently facing issues on TNC 426

--> When I use R_VR without additonal Parameter on TNC426:

SEND:
b'\x00\x00\x00\x00R_VR' Receive: b'\x00\x00\x00$S_VRTNC 426/430M\x00280476 24 \x00GR495.07SA\x00\x00'

--> When I use R_VR without additonal Parameter on iTNC530:

SEND: b'\x00\x00\x00\x00R_VR' Receive: b'\x00\x00\x004S_VRiTNC530\x00340490 06 SP3\x00800A_AA.PLC\x00%0000111100000000\x00'

But the Lib is using b'\x00\x00\x00\x00R_VR\0x01' for getting the infos which is not working on TNC426

SEND: b'\x00\x00\x00\x01R_VR\x01' Receive: b'\x00\x00\x00\x08S_VRiTNC530\x00'

This is the definiton in the docu --> Without additonal infos

If their is no technical reason against it I would try to change the command setting to the specification and try it with TNC426

Thanks

[drunsinn]

Servus @patrickschultes!

if I remember correctly I went by a note I found in the version of the LSV2 documentation I have. Since getting each value separately made decoding the data easier, I went with the current implementation.

I don't see any reason not to change the current behavior to also support the TNC426. If you could do the changes, that would be great! I am currently working on a side project to have as many of the old programing station versions available in a Windows VM as possible so I can automate the tests for pyLSV2 easier. Your changes would be a grate first use for broader testing!

Danke schon mal!

[drunsinn]

@patrickschultes any updates from your side regarding this problem? Have you started implementing a solution? Otherwise i can look into this since I got some free time on my hands.

[patrick-gaertner]

Servus, @drunsinn it is still on my todo list but currently not with the highest priority. So usually in the next weeks I can run some tests on our old machine. Currently I am fighting against Siemens controllers 😅

[drunsinn]

Great! I will create a new branch to split R_VR into seperate steps. Would be grate i you could check the results later when you have time!