LatLongToTimezone icon indicating copy to clipboard operation
LatLongToTimezone copied to clipboard

Update to the latest TZ Shapefiles

Open mvrhov opened this issue 8 years ago • 6 comments

Unfortunately, the timezones are changed in various countries a couple a times a year. So the TZ database gets updated. It would be nice to update the data to latest TZ shapefiles at least twice a year.

mvrhov avatar Jun 08 '16 06:06 mvrhov

I join the request! Please fix it.

sankarsana avatar Aug 04 '16 15:08 sankarsana

It appears that regularly updated shapefiles are available from here: https://github.com/evansiroky/timezone-boundary-builder. Could they function as an updated source for this project?

stephent avatar Jun 14 '18 18:06 stephent

I have a fix available for it. I've picked the latest shapefiles and updated this library with the latest timezone. @drtimcooper How can I contribute ?

darpandhamija avatar Jan 30 '19 20:01 darpandhamija

@darpandhamija Have you executed the code to create the target java/csharp/objectivec code? Does the new version of the files work? You should test it with at least one of the supported languages. If it works then: are you familiar with git? Can you create a git pull request? I'll merge it if you're confident that it works.

drtimcooper avatar Jan 31 '19 10:01 drtimcooper

Yes @drtimcooper, I had to update the convertingShapeFilesToJson,

  • I've upgraded to latest ShapeFile lib version.
  • I had to update toJson.c for creating polygons from new shapefiles
  • update paths on TimeZoneMapperConverter.java to more generic ones to finally generate .java and .swift files.
  • I've added some more test cases for the file and compared the result with other libraries and Google Timezone API response and it has improved results as compared to before. Something that'll resolve another issue : https://github.com/drtimcooper/LatLongToTimezone/issues/19

I am familiar with git and create PullRequest for you to merge.

darpandhamija avatar Feb 01 '19 19:02 darpandhamija

Hi @darpandhamija : Thanks for your hard work! But I can't see your Pull Request. I can only see one PR and it's not yours. Can you try again?

drtimcooper avatar Feb 04 '19 07:02 drtimcooper