Artem S. Povalyukhin

Results 69 comments of Artem S. Povalyukhin

@xeioex Please take a look: Improved fs.mkdir() to support recursive directory creation. https://gist.github.com/drsm/342c4300b17b90cf749f3e316fc3b403

@xeioex Improved fs.rmdir() to support recursive directory removal. https://gist.github.com/drsm/38714fecb523293d70296741cb62eb02 The upstream solution is still [buggy](https://github.com/nodejs/node/issues/34278)

@xeioex > Take a look, https://gist.github.com/xeioex/cf5d4d451642510777552614ca1396af > > Coverity (static analyser) found the [following issue ](https://en.wikipedia.org/wiki/Time-of-check_to_time-of-use) with the previous mkdir patch. Yes, there is a race condition. I was unsure...

@xeioex > The fix looks fine to me. BTW, we may lose an original `mkdir()` `errno` after stat: https://github.com/openbsd/src/blob/master/bin/mkdir/mkdir.c#L150 but i don't think it's a serous issue.

@xeioex Thanks! [This](https://github.com/nginx/njs/blob/master/src/njs_fs.c#L1565) place is questionable: ```js >> fs.realpath(Buffer.from('/none'), (e) => void console.log(e.path)) undefined Buffer [47,110,111,110,101] ``` vs. ```js > fs.realpath(Buffer.from('/none'), (e) => void console.log(e.path)) undefined > /none ```

@xeioex Fixed version (arrows cannot be used, because of lexical `this`): ```js function Rectangle(height, width) { this.height = height; this.width = width; } Object.defineProperty(Rectangle.prototype, 'area', { get: function() { return...

Also, we need a - proper [IsConstuctor](https://tc39.es/ecma262/#sec-isconstructor) : ```js > class X { constructor() { console.log('test'); } } undefined > X() Thrown: TypeError: Class constructor X cannot be invoked without...

@hongzhidao Hi! > It seems `assignment statement` is allowed. > But I can't find the spec in [ecma262](https://tc39.es/ecma262/#prod-ClassElement). It's an instance field: [Stage 3 Draft](https://tc39.es/proposal-class-fields/#sec-intro)

@hongzhidao > It seems imported variables `a` and `b` are reference. Yes. Imports are not variables at all, they are just named references to the other module memory substituted at...